Work around GEOS issue in voronoi_frames #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
=======================================
+ Coverage 84.7% 84.9% +0.2%
=======================================
Files 141 141
Lines 15200 15206 +6
=======================================
+ Hits 12880 12913 +33
+ Misses 2320 2293 -27
|
jGaboardi
approved these changes
Mar 25, 2024
|
Is this something that might be fixed in the future upstream? If so, should we make a ticket here to check the behavior in the future? Or will the workaround continue to be functional after the upstream issue is resolved? |
|
I suppose it will be fixed in upstream. The if clause will be just skipped in that case, like it is in most cases where the issue does not happen right now. This is a very corner case but it was causing an issue when running enclosed_tessellation in momepy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the new
voronoi_frameson a fairly large dataset, I noticed this issue libgeos/geos#1062 plus another where some polygons coming from GEOS were not actually valid, likely due to the same reason. This is a workaround that solves all I faced.